lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAPj87rPgvjs5W68Cou6ODDqbqbPXQvFxLPtegBkdxdtPaRMX7A@mail.gmail.com> Date: Tue, 24 May 2016 09:19:10 +0200 From: Daniel Stone <daniel@...ishbar.org> To: Tomeu Vizoso <tomeu.vizoso@...labora.com> Cc: "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, linux-rockchip <linux-rockchip@...ts.infradead.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, dri-devel <dri-devel@...ts.freedesktop.org> Subject: Re: [PATCH] drm/rockchip: Return -EBUSY if there's already a pending flip event v3 Hi Tomeu, On 5 April 2016 at 16:07, Tomeu Vizoso <tomeu.vizoso@...labora.com> wrote: > On 4 April 2016 at 17:44, Daniel Stone <daniel@...ishbar.org> wrote: >> On 4 April 2016 at 14:55, Tomeu Vizoso <tomeu.vizoso@...labora.com> wrote: >>> + if (async) { >>> + for_each_crtc_in_state(state, crtc, crtc_state, i) { >>> + if (crtc->state->event || >>> + rockchip_drm_crtc_has_pending_event(crtc)) { >>> + return -EBUSY; >>> + } >>> + } >>> + } >> >> Hmmm ... >> >> Doesn't this trigger before the VOP atomic_begin() helper, meaning >> that anything with an event set will trigger the check? Seems like it >> should be && rather than ||. > > So, these are the two cases that this code aims to handle: > > 1. A previous request with an event set hasn't progressed to > atomic_begin yet, so the event field in drm_crtc_state (at this point, > the old state) is still populated but vop->event still isn't. Ah right, this was what I was missing: the async (non-blocking) implementation. Sounds good to me then. Cheers, Daniel
Powered by blists - more mailing lists