linux-kernel - Re: [PATCH v2 1/2] pinctrl: Add Oxford Semiconductor OXNAS pinctrl and gpio driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZPMqRNn9rmcC4HYVKrdS7cxBD7O7oE4YPrP7L-0_Wakg@mail.gmail.com>
Date:	Tue, 24 May 2016 11:35:20 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Neil Armstrong <narmstrong@...libre.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] pinctrl: Add Oxford Semiconductor OXNAS pinctrl
 and gpio driver

On Wed, May 11, 2016 at 9:34 AM, Neil Armstrong <narmstrong@...libre.com> wrote:

> Add pinctrl and gpio control support to Oxford Semiconductor OXNAS SoC Family.
> This version supports the ARM926EJ-S based OX810SE SoC with 34 IO pins.
>
> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>

I tried implementing a .get_direction() callback for the Oxnas GPIO
(this is good to have, for debugfs and for the new userspace ABI).

However:

> +/* GPIO Registers */
> +#define INPUT_VALUE    0x00
> +#define IRQ_PENDING    0x0c
> +#define OUTPUT_SET     0x14
> +#define OUTPUT_CLEAR   0x18
> +#define OUTPUT_EN_SET  0x1c
> +#define OUTPUT_EN_CLEAR        0x20
> +#define RE_IRQ_ENABLE  0x28
> +#define FE_IRQ_ENABLE  0x2c

No pure OUTPUT_EN register to read the direction from?
Or is it one of the undocumented ones?

Could you take a stab at implementing .get_direction() and
send a patch?

Yours,
Linus Walleij