| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1464095335-27730-1-git-send-email-vincent.guittot@linaro.org> Date: Tue, 24 May 2016 15:08:55 +0200 From: Vincent Guittot <vincent.guittot@...aro.org> To: peterz@...radead.org, mingo@...nel.org, linux-kernel@...r.kernel.org Cc: yuyang.du@...el.com, dietmar.eggemann@....com, Vincent Guittot <vincent.guittot@...aro.org> Subject: [PATCH] sched: fix first task of a task group is attached twice The cfs_rq->avg.last_update_time is initialize to 0 with the main effect that the 1st sched_entity that will be attached, will keep its last_update_time set to 0 and will attached once again during the enqueue. Initialize cfs_rq->avg.last_update_time to current rq's clock Signed-off-by: Vincent Guittot <vincent.guittot@...aro.org> --- kernel/sched/fair.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 218f8e8..a4e2c10 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8586,6 +8586,14 @@ void init_tg_cfs_entry(struct task_group *tg, struct cfs_rq *cfs_rq, se->depth = parent->depth + 1; } + /* + * Set last_update_time to something different from 0 to make + * sure the 1st sched_entity will not be attached twice: once + * when attaching the task to the group and one more time when + * enqueueing the task. + */ + tg->cfs_rq[cpu]->avg.last_update_time = rq_clock_task(rq_of(cfs_rq)); + se->my_q = cfs_rq; /* guarantee group entities always have weight */ update_load_set(&se->load, NICE_0_LOAD); -- 1.9.1
Powered by blists - more mailing lists