linux-kernel - Re: [RFC PATCH] usb: gadget: Introduce Cadence USB2 UDC Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 May 2016 16:16:16 +0200
From:	Neil Armstrong <narmstrong@...libre.com>
To:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [RFC PATCH] usb: gadget: Introduce Cadence USB2 UDC Driver

Hi Felipe, Laurent,

I submitted this driver for a Cadence IP library from a now abandoned project.

The driver was working on a SoC platform ported on a FPGA, but I do not have access to this HW anymore.

But I have a fixed version...

Now, I am looking for SoCs, vendors and even Cadence people (or even Evatronix employees who worked on this IP before being in Cadence portfolio)
to push this driver upstream by testing it on a real HW or even FPGA.

I hope this message in a bottle will get read !

Regards,
Neil

On 11/16/2015 05:11 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Neil Armstrong <narmstrong@...libre.com> writes:
>> Introduces UDC support for the Device-Mode only version of the
>> Cadence USB2 Controller IP Core.
>>
>> Host mode and OTG mode are not implemented by lack of hardware.
>> Support for Isochronous endpoints is not implemented by lack of time.
>>
>> Internal DMA is supported and can be activated by DT property.
>>
>> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
> 
> looks like there are a few checkpatch warnings to be fixed:
> 
> WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
> #89: 
> new file mode 100644
> 
> WARNING: 'tranfer' may be misspelled - perhaps 'transfer'?
> #233: FILE: drivers/usb/gadget/udc/cadence_hsudc.c:44:
> + *  - EP Bulk and Interrupt tranfer
> 
> WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
> #968: FILE: drivers/usb/gadget/udc/cadence_hsudc.c:779:
> +	BUG();
> 
> WARNING: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON()
> #1492: FILE: drivers/usb/gadget/udc/cadence_hsudc.c:1303:
> +		BUG();
> 
> WARNING: DT compatible string "cdns,usbhs-udc" appears un-documented -- check workspace/linux/Documentation/devicetree/bindings/
> #1882: FILE: drivers/usb/gadget/udc/cadence_hsudc.c:1693:
> +	{ .compatible = "cdns,usbhs-udc" },
> 
> WARNING: 'tranfer' may be misspelled - perhaps 'transfer'?
> #2603: FILE: drivers/usb/gadget/udc/cadence_hsudc_regs.h:272:
> +#define HSUDC_DMA_BUSCTRL_HSIZE_8BIT	(0 << 1) /* 8-bit data tranfer */
> 
> WARNING: 'tranfer' may be misspelled - perhaps 'transfer'?
> #2604: FILE: drivers/usb/gadget/udc/cadence_hsudc_regs.h:273:
> +#define HSUDC_DMA_BUSCTRL_HSIZE_16BIT	(1 << 1) /* 16-bit data tranfer */
> 
> WARNING: 'tranfer' may be misspelled - perhaps 'transfer'?
> #2605: FILE: drivers/usb/gadget/udc/cadence_hsudc_regs.h:274:
> +#define HSUDC_DMA_BUSCTRL_HSIZE_32BIT	(2 << 1) /* 32-bit data tranfer */
> 
> WARNING: 'tranfer' may be misspelled - perhaps 'transfer'?
> #2607: FILE: drivers/usb/gadget/udc/cadence_hsudc_regs.h:276:
> +#define HSUDC_DMA_BUSCTRL_BURST_SINGLE	(0 << 4) /* Single tranfer */
> 
> total: 0 errors, 9 warnings, 2499 lines checked
> 
> Your patch has style problems, please review.
> 
> NOTE: If any of the errors are false positives, please report
>       them to the maintainer, see CHECKPATCH in MAINTAINERS.
> 




Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)