linux-kernel - Re: [PATCH] power_suply: isp1704_charger: Fix isp1704

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160524153206.GU29844@pali>
Date:	Tue, 24 May 2016 17:32:06 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>, sre@...nel.org
Cc:	dbaryshkov@...il.com, dwmw2@...radead.org,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
	Pavel Machek <pavel@....cz>
Subject: Re: [PATCH] power_suply: isp1704_charger: Fix isp1704_write()
 definition

On Thursday 19 May 2016 11:13:04 Pali Rohár wrote:
> On Saturday 09 January 2016 23:42:30 Pali Rohár wrote:
> > On Friday 01 January 2016 12:26:21 Pali Rohár wrote:
> > > On Friday 01 January 2016 12:03:29 Ivaylo Dimitrov wrote:
> > > > All calls to isp1704_write() are using parameter sequence of
> > > > isp1704_write(isp, reg, val) but the function is defined as
> > > > isp1704_write(isp, val, reg). Fix isp1704_write function definition
> > > > so that the driver to be functional.
> > > > 
> > > > Signed-off-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@...il.com>
> > > 
> > > Reviewed-by: Pali Rohár <pali.rohar@...il.com>
> > > 
> > > This problem is there since inclusion of driver itself. No idea why
> > > that driver could work... I remember that it detected correctly type
> > > of charger.
> > > 
> > > I will test this patch on real N900 HW in one or two weeks to check
> > > how it behave after patching...
> > 
> > Tested-by: Pali Rohár <pali.rohar@...il.com>
> > 
> > Please send this patch to all stable kernels.
> 
> Hi! I still think that this patch should go to stable kernels. Because
> without it driver does not work... Will somebody send it to stable?

So no objections, I sent it to stable@...r.kernel.org.

-- 
Pali Rohár
pali.rohar@...il.com