lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAJvTdKn9XyutRAk4Hf5tarQVkCQ4QQL3wtM5RHYfsMg8P3mhnA@mail.gmail.com> Date: Tue, 24 May 2016 12:09:56 -0400 From: Len Brown <lenb@...nel.org> To: "Chen, Yu C" <yu.c.chen@...el.com> Cc: Ingo Molnar <mingo@...nel.org>, "mingo@...hat.com" <mingo@...hat.com>, "tglx@...utronix.de" <tglx@...utronix.de>, "hpa@...or.com" <hpa@...or.com>, "rjw@...ysocki.net" <rjw@...ysocki.net>, "pavel@....cz" <pavel@....cz>, "Brown, Len" <len.brown@...el.com>, "luto@...nel.org" <luto@...nel.org>, "bp@...e.de" <bp@...e.de>, "linux@...izon.com" <linux@...izon.com>, "Kaszewski, Marcin" <marcin.kaszewski@...el.com>, "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>, "x86@...nel.org" <x86@...nel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Matthew Garrett <mjg59@...f.ucam.org> Subject: Re: [PATCH][v7] x86, suspend: Save/restore extra MSR registers for suspend +mjg59, who may be seeing this issue on a skylake laptop Chen-yu, Great debugging, but I think there is a more general fix possible than this DMI quirk. I agree that in this example, a grantley server, it seems the BIOS is erroneously returning a bogus value of MSR_IA32_THERM_CONTROL on resume from S3. But another scenario is also possible. Consider a laptop that is resuming HOT and the BIOS correctly enables throttling. If this code were invoked, it would restore the COLD setting. Instead, it seems to me that the ACPI processor driver should upon .resume check if throttling should be enabled or not, and proceed accordingly. That would always do the "right thing", and would not need a DMI list. Does that make sense? thanks, Len Brown, Intel Open Source Technology Center
Powered by blists - more mailing lists