lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20160524163411.GA21800@kroah.com> Date: Tue, 24 May 2016 09:34:11 -0700 From: Greg KH <gregkh@...uxfoundation.org> To: Bart Van Assche <bart.vanassche@...disk.com> Cc: "Bryant G. Ly" <bryantly@...ux.vnet.ibm.com>, JBottomley@...n.com, martin.petersen@...cle.com, tyreld@...ux.vnet.ibm.com, akpm@...ux-foundation.org, kvalo@...eaurora.org, davem@...emloft.net, mchehab@....samsung.com, jslaby@...e.com, joe@...ches.com, bp@...e.de, linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org, target-devel@...r.kernel.org, bgly <bgly@...ibm.com> Subject: Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver On Tue, May 24, 2016 at 09:25:05AM -0700, Bart Van Assche wrote: > > +static inline long h_send_crq(struct ibmvscsis_adapter *adapter, > > + u64 word1, u64 word2) > > +{ > > + long rc; > > + struct vio_dev *vdev = adapter->dma_dev; > > + > > + pr_debug("ibmvscsis: ibmvscsis_send_crq(0x%x, 0x%016llx, 0x%016llx)\n", > > + vdev->unit_address, word1, word2); > > + > > As Joe Perches already asked, please define pr_fmt() instead of including > the kernel module name in every pr_debug() statement. Even better, as this is a driver, it should be using dev_*() calls instead of pr_*() calls to properly identify the device and driver that is making the message. No driver should be using pr_*() except in _very_ limited usages. thanks, greg k-h
Powered by blists - more mailing lists