linux-kernel - Re: [PATCH] MIPS: Add missing FROZEN hotplug notifier transitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57449A28.3020901@gmail.com>
Date:	Tue, 24 May 2016 11:15:04 -0700
From:	David Daney <ddaney.cavm@...il.com>
To:	Anna-Maria Gleixner <anna-maria@...utronix.de>
CC:	linux-kernel@...r.kernel.org, rt@...utronix.de,
	Ralf Baechle <ralf@...ux-mips.org>, linux-mips@...ux-mips.org
Subject: Re: [PATCH] MIPS: Add missing FROZEN hotplug notifier transitions

On 05/24/2016 06:08 AM, Anna-Maria Gleixner wrote:
> The corresponding FROZEN hotplug notifier transitions used on
> suspend/resume are ignored. Therefore the switch case action argument
> is masked with the frozen hotplug notifier transition mask.
>
> Cc: Ralf Baechle <ralf@...ux-mips.org>
> Cc: linux-mips@...ux-mips.org
> Signed-off-by: Anna-Maria Gleixner <anna-maria@...utronix.de>

This seems sane, and I don't object, but can you tell us how this was 
tested?

Thanks,
David Daney


> ---
>   arch/mips/cavium-octeon/smp.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/arch/mips/cavium-octeon/smp.c
> +++ b/arch/mips/cavium-octeon/smp.c
> @@ -384,7 +384,7 @@ static int octeon_cpu_callback(struct no
>   {
>   	unsigned int cpu = (unsigned long)hcpu;
>
> -	switch (action) {
> +	switch (action & ~CPU_TASKS_FROZEN) {
>   	case CPU_UP_PREPARE:
>   		octeon_update_boot_vector(cpu);
>   		break;
>
>