lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <96cee774e7a4269a73b0fcd476d8af575c10ac00.1464115008.git.amsfield22@gmail.com> Date: Tue, 24 May 2016 12:17:27 -0700 From: Alison Schofield <amsfield22@...il.com> To: jic23@...nel.org Cc: lars@...afoo.de, Michael.Hennerich@...log.com, knaack.h@....de, pmeerw@...erw.net, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org Subject: [PATCH 3/7] iio: adc: ad7793: claim direct mode when writing frequency Driver was checking for direct mode and trying to lock it, but left a gap where mode could change before the desired operation. Use iio_device_claim_direct_mode() to guarantee device stays in direct mode. Signed-off-by: Alison Schofield <amsfield22@...il.com> Cc: Daniel Baluta <daniel.baluta@...il.com> --- drivers/iio/adc/ad7793.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c index 7b07bb6..3f41cd8 100644 --- a/drivers/iio/adc/ad7793.c +++ b/drivers/iio/adc/ad7793.c @@ -369,13 +369,6 @@ static ssize_t ad7793_write_frequency(struct device *dev, long lval; int i, ret; - mutex_lock(&indio_dev->mlock); - if (iio_buffer_enabled(indio_dev)) { - mutex_unlock(&indio_dev->mlock); - return -EBUSY; - } - mutex_unlock(&indio_dev->mlock); - ret = kstrtol(buf, 10, &lval); if (ret) return ret; @@ -387,12 +380,14 @@ static ssize_t ad7793_write_frequency(struct device *dev, for (i = 0; i < 16; i++) if (lval == st->chip_info->sample_freq_avail[i]) { - mutex_lock(&indio_dev->mlock); + ret = iio_device_claim_direct_mode(indio_dev); + if (ret) + return ret; st->mode &= ~AD7793_MODE_RATE(-1); st->mode |= AD7793_MODE_RATE(i); ad_sd_write_reg(&st->sd, AD7793_REG_MODE, sizeof(st->mode), st->mode); - mutex_unlock(&indio_dev->mlock); + iio_device_release_direct_mode(indio_dev); ret = 0; } -- 2.1.4
Powered by blists - more mailing lists