lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CA+55aFyUhv1qQMkON1S+_trQ+4iwd2S4Ty8BHe=g-SPLTscasg@mail.gmail.com> Date: Tue, 24 May 2016 15:44:15 -0700 From: Linus Torvalds <torvalds@...ux-foundation.org> To: Arnd Bergmann <arnd@...db.de> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Linux FS Devel <linux-fsdevel@...r.kernel.org>, Deepa Dinamani <deepa.kernel@...il.com>, Thomas Gleixner <tglx@...utronix.de>, Al Viro <viro@...iv.linux.org.uk> Subject: Re: [GIT PULL] y2038 changes for vfs On Tue, May 24, 2016 at 3:23 PM, Linus Torvalds <torvalds@...ux-foundation.org> wrote: > > Just as an example: code that does > > dir->i_mtime = dir->i_ctime = CURRENT_TIME_SEC; > > could pretty mechanically be converted to > > dir->i_mtime = dir->i_ctime = current_fs_time(sb); Actually, looking at the users, most of them don't have the superblock directly as a variable, so it might be better to just make current_fs_time() take the inode pointer instead. That would make the conversion simpler, and it can then do the inode->i_sb thing when it is converted to actually take the filesystem limits and time granularity into account. I suspect you could do 95% with a fairly simply coccinelle script. Or even just use 'sed', with something like sed 's/\([a-z]*\)->i_\([amc]\)time = CURRENT_TIME_SEC/\1->i_\2time = current_fs_time(\1)/' seems to get close. Run that over the tree, fix up the few cases it doesn't catch, remove the broken CURRENT_TIME_SEC thing, and voilá, you're pretty much done. No? Linus
Powered by blists - more mailing lists