linux-kernel - Re: [PATCH] pinctrl: digicolor: add missing platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160525064832.GG2178@tarshish>
Date:	Wed, 25 May 2016 09:48:32 +0300
From:	Baruch Siach <baruch@...s.co.il>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	linux-gpio@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] pinctrl: digicolor: add missing platform_set_drvdata()
 call

Hi Masahiro Yamada,

On Wed, May 25, 2016 at 02:58:52PM +0900, Masahiro Yamada wrote:
> gc_pinctrl_remove() calls platform_get_drvdata(), but I see neither
> platform_set_drvdata() nor dev_set_drvdata() anywhere in this driver.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Acked-by: Baruch Siach <baruch@...s.co.il>

Thanks,
baruch

>  drivers/pinctrl/pinctrl-digicolor.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/pinctrl/pinctrl-digicolor.c b/drivers/pinctrl/pinctrl-digicolor.c
> index 30ee564..c8073d4 100644
> --- a/drivers/pinctrl/pinctrl-digicolor.c
> +++ b/drivers/pinctrl/pinctrl-digicolor.c
> @@ -332,6 +332,8 @@ static int dc_pinctrl_probe(struct platform_device *pdev)
>  		return PTR_ERR(pmap->pctl);
>  	}
>  
> +	platform_set_drvdata(pdev, pmap);
> +
>  	return dc_gpiochip_add(pmap, pdev->dev.of_node);
>  }

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -