linux-kernel - [PATCH 1/2 v2] drm: rcar-du: error message is not needed for drm_vblank

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87posbkmbj.wl%kuninori.morimoto.gx@renesas.com>
Date:	Wed, 25 May 2016 00:40:26 +0000
From:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	David Airlie <airlied@...ux.ie>
CC:	<dri-devel@...ts.freedesktop.org>,
	<linux-renesas-soc@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <koji.matsuoka.xm@...esas.com>,
	<yoshihiro.shimoda.uh@...esas.com>, <naoya.shiiba.nx@...esas.com>,
	<ryo.kodama.vz@...esas.com>, <hiroyuki.yokoyama.vx@...esas.com>,
	<yoshifumi.hosoya.wj@...esas.com>, <takeshi.kihara.df@...esas.com>,
	<toshiaki.komatsu.ud@...esas.com>,
	<harunobu.kurokawa.dn@...esas.com>,
	<ryusuke.sakato.bx@...esas.com>, <tomoharu.fukawa.eb@...esas.com>,
	<kouei.abe.cp@...esas.com>, <khiem.nguyen.xt@....renesas.com>,
	<hien.dang.eb@....renesas.com>
Subject: [PATCH 1/2 v2] drm: rcar-du: error message is not needed for drm_vblank_init()

From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

The only reason drm_vblank_init() could return an error at the
moment is a kcalloc() failure.
So we can remove current error message completely.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
---
v1 -> v2

 - just removed error message

 drivers/gpu/drm/rcar-du/rcar_du_drv.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 26fd3ba..786f5d6 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -353,10 +353,8 @@ static int rcar_du_probe(struct platform_device *pdev)
 	 * disabled for all CRTCs.
 	 */
 	ret = drm_vblank_init(ddev, (1 << rcdu->info->num_crtcs) - 1);
-	if (ret < 0) {
-		dev_err(&pdev->dev, "failed to initialize vblank\n");
+	if (ret < 0)
 		goto error;
-	}
 
 	/* DRM/KMS objects */
 	ret = rcar_du_modeset_init(rcdu);
-- 
1.9.1