linux-kernel - Re: [PATCH 00/10] String hash improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160525081128.6920.qmail@ns.sciencehorizons.net>
Date:	25 May 2016 04:11:28 -0400
From:	"George Spelvin" <linux@...encehorizons.net>
To:	geert@...ux-m68k.org, linux@...encehorizons.net
Cc:	alistair.francis@...inx.com, bfields@...ldses.org,
	gerg@...ux-m68k.org, jlayton@...chiereds.net,
	linux-kernel@...r.kernel.org, linux-m68k@...ts.linux-m68k.org,
	linux-nfs@...r.kernel.org, michal.simek@...inx.com,
	tglx@...utronix.de, torvalds@...ux-foundation.org,
	uclinux-h8-devel@...ts.sourceforge.jp, ysato@...rs.sourceforge.jp
Subject: Re: [PATCH 00/10] String hash improvements

Geert Uytterhoeven wrote:
> Usually this is handled through include/asm-generic/.
> Put the generic default implementation in include/asm-generic/hash.h.
>
> Architectures that need to override provide their own version, e.g.
> arch/m68k/include/asm/hash.h. They may #include <asm-generic/hash.h>
> if they still want to reuse parts of the generic implementation.
>
> Other architectures add "generic-y += hash.h" to their
> arch/<ARCH>/include/asm/Kbuild.

I thought about that, but then I'd have to edit *every* architecture,
and might need acks from all the maintainers.

I was looking for something that was a total no-op on most architectures.

But if this is preferred, it's not technically difficult at all.


If asm-generic were in the <asm/*.h> search path, it would magically
Just Work, but leftover files from a broken checkout would be a big
potential problem.