linux-kernel - Re: [PATCH 1/7] iio: adc: ad7266: claim direct mode during sensor read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZBY94SXut69-o0wvXtiAw3qTxfEnaYbk_uG8qRkeUCbgQ@mail.gmail.com>
Date:	Wed, 25 May 2016 13:33:28 +0300
From:	Daniel Baluta <daniel.baluta@...il.com>
To:	Alison Schofield <amsfield22@...il.com>
Cc:	Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	"Hennerich, Michael" <Michael.Hennerich@...log.com>,
	Hartmut Knaack <knaack.h@....de>,
	Peter Meerwald-Stadler <pmeerw@...erw.net>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/7] iio: adc: ad7266: claim direct mode during sensor read

On Tue, May 24, 2016 at 10:16 PM, Alison Schofield <amsfield22@...il.com> wrote:
> Driver was checking for direct mode but not locking it down.
> Use iio_device_claim_direct_mode() to guarantee device stays
> in direct mode.
>
> Signed-off-by: Alison Schofield <amsfield22@...il.com>
> Cc: Daniel Baluta <daniel.baluta@...il.com>

Acked-by: Daniel Baluta <daniel.baluta@...il.com>

> ---
>  drivers/iio/adc/ad7266.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/adc/ad7266.c b/drivers/iio/adc/ad7266.c
> index 21e19b6..01240ae 100644
> --- a/drivers/iio/adc/ad7266.c
> +++ b/drivers/iio/adc/ad7266.c
> @@ -154,12 +154,11 @@ static int ad7266_read_raw(struct iio_dev *indio_dev,
>
>         switch (m) {
>         case IIO_CHAN_INFO_RAW:
> -               if (iio_buffer_enabled(indio_dev))
> -                       return -EBUSY;
> -
> -               ret = ad7266_read_single(st, val, chan->address);
> +               ret = iio_device_claim_direct_mode(indio_dev);
>                 if (ret)
>                         return ret;
> +               ret = ad7266_read_single(st, val, chan->address);
> +               iio_device_release_direct_mode(indio_dev);
>
>                 *val = (*val >> 2) & 0xfff;
>                 if (chan->scan_type.sign == 's')
> --