linux-kernel - Re: [PATCH v3] sched/cputime: add steal time support to full dynticks CPU time accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cce99ac3-3cae-0386-59ed-7de9a3613815@redhat.com>
Date:	Wed, 25 May 2016 12:35:45 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Wanpeng Li <kernellwp@...il.com>, Rik van Riel <riel@...hat.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	kvm <kvm@...r.kernel.org>, Wanpeng Li <wanpeng.li@...mail.com>,
	Ingo Molnar <mingo@...nel.org>,
	"Peter Zijlstra (Intel)" <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Radim <rkrcmar@...hat.com>
Subject: Re: [PATCH v3] sched/cputime: add steal time support to full dynticks
 CPU time accounting



On 25/05/2016 04:16, Wanpeng Li wrote:
> Ping Paolo or Peterz.

No need to ping, since Rik reviewed it 7 hours ago so the thread has
gotten a bump in our mailboxes.

And anyway this is the merge window, which is the most annoying time to
get pings and one-patch changes.  I don't mind at all getting large
series during the merge window, but the small ones definitely can wait a
week or two.

Thanks,

Paolo

> 2016-05-25 3:22 GMT+08:00 Rik van Riel <riel@...hat.com>:
>> On Wed, 2016-05-18 at 20:27 +0800, Wanpeng Li wrote:
>>> From: Wanpeng Li <wanpeng.li@...mail.com>
>>>
>>> This patch adds steal guest time support to full dynticks CPU
>>> time accounting. After 'commit ff9a9b4c4334 ("sched, time: Switch
>>> VIRT_CPU_ACCOUNTING_GEN to jiffy granularity")', time is jiffy
>>> based sampling even if it's still listened to ring boundaries, so
>>> steal_account_process_tick() is reused to account how much 'ticks'
>>> are steal time after the last accumulation.
>>>
>>> Suggested-by: Rik van Riel <riel@...hat.com>
>>> Cc: Ingo Molnar <mingo@...nel.org>
>>> Cc: Peter Zijlstra (Intel) <peterz@...radead.org>
>>> Cc: Rik van Riel <riel@...hat.com>
>>> Cc: Thomas Gleixner <tglx@...utronix.de>
>>> Cc: Frederic Weisbecker <fweisbec@...il.com>
>>> Cc: Paolo Bonzini <pbonzini@...hat.com>
>>> Cc: Radim <rkrcmar@...hat.com>
>>> Signed-off-by: Wanpeng Li <wanpeng.li@...mail.com>
>>
>> This also nicely fixes up f9c904b7613b ("sched/cputime:
>> Fix steal_account_process_tick() to always return jiffies"),
>> which relies on a bool function returning a certain number
>> of jiffies :)
>>
>> Reviewed-by: Rik van Riel <riel@...hat.com>
>>
>> --
>> All rights reversed
> 
> 
>