linux-kernel - Re: [PATCH 3/3] ibmvscsis: clean up functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1464187479.16344.14.camel@perches.com>
Date:	Wed, 25 May 2016 07:44:39 -0700
From:	Joe Perches <joe@...ches.com>
To:	"Bryant G. Ly" <bryantly@...ux.vnet.ibm.com>,
	tyreld@...ux.vnet.ibm.com, bart.vanassche@...disk.com
Cc:	martin.petersen@...cle.com, akpm@...ux-foundation.org,
	kvalo@...eaurora.org, davem@...emloft.net, mchehab@....samsung.com,
	jslaby@...e.com, bp@...e.de, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org, target-devel@...r.kernel.org
Subject: Re: [PATCH 3/3] ibmvscsis: clean up functions

On Wed, 2016-05-25 at 09:17 -0500, Bryant G. Ly wrote:
> From: bryantly <bryantly@...ux.vnet.ibm.com>

Please use your whole name here and for your sign-off like:

From: Bryant G. Ly <bryantly@...ux.vnet.ibm.com>
Signed-off-by: Bryant G. Ly <bryantly@...ux.vnet.ibm.com>

> This patch removes forward declarations and re-organizes the
> functions within the driver. This patch also fixes MAINTAINERS
> for ibmvscsis.

trivial note:

> diff --git a/drivers/scsi/ibmvscsi/ibmvscsis.c b/drivers/scsi/ibmvscsi/ibmvscsis.c
[]
>  static inline long h_copy_rdma(s64 length, u64 sliobn, u64 slioba,
>  			       u64 dliobn, u64 dlioba)
>  {
> 

Functions like this would be less indented and less
line wrapped for 80 columns if they were written:

	if (!se_cmd->residual_count)
		return;

	[unindented one level...]

etc...