linux-kernel - Re: Regression in 4.6.0-git - bisected to commit dd254f5a382c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D96BE40A-E47A-4DA0-B865-3A88064AE2EE@codeaurora.org>
Date:	Wed, 25 May 2016 10:27:18 -0500
From:	Matthew McClintock <mmcclint@...eaurora.org>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Regression in 4.6.0-git - bisected to commit dd254f5a382c

On May 25, 2016, at 1:24 AM, Al Viro <viro@...iv.linux.org.uk> wrote:
> 
> diff --git a/lib/iov_iter.c b/lib/iov_iter.c
> index 28cb431..0cd5227 100644
> --- a/lib/iov_iter.c
> +++ b/lib/iov_iter.c
> @@ -101,7 +101,7 @@
> #define iterate_and_advance(i, n, v, I, B, K) {			\
> 	if (unlikely(i->count < n))				\
> 		n = i->count;					\
> -	if (n) {						\
> +	if (i->count) {						\
> 		size_t skip = i->iov_offset;			\
> 		if (unlikely(i->type & ITER_BVEC)) {		\
> 			const struct bio_vec *bvec;		\
> 
> Could you see if your reproducer is fixed by that?

Yes, this fixes my issue.

-M