linux-kernel - Re: [PATCH v3] Axi-usb: Add support for 64-bit addressing.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160525173419.GA7510@rob-hp-laptop>
Date:	Wed, 25 May 2016 12:34:19 -0500
From:	Rob Herring <robh@...nel.org>
To:	Nava kishore Manne <nava.manne@...inx.com>
Cc:	Arnd Bergmann <arnd@...db.de>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	"galak@...eaurora.org" <galak@...eaurora.org>,
	Michal Simek <michals@...inx.com>,
	Soren Brinkmann <sorenb@...inx.com>,
	"balbi@...com" <balbi@...com>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	Hyun Kwon <hyunk@...inx.com>,
	Radhey Shyam Pandey <radheys@...inx.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] Axi-usb: Add support for 64-bit addressing.

On Tue, May 24, 2016 at 11:47:31AM +0000, Nava kishore Manne wrote:
> 
> 
> > -----Original Message-----
> > From: Arnd Bergmann [mailto:arnd@...db.de]
> > Sent: Tuesday, May 24, 2016 2:21 PM
> > To: Nava kishore Manne <navam@...inx.com>
> > Cc: robh+dt@...nel.org; pawel.moll@....com; mark.rutland@....com;
> > ijc+devicetree@...lion.org.uk; galak@...eaurora.org; Michal Simek
> > <michals@...inx.com>; Soren Brinkmann <sorenb@...inx.com>;
> > balbi@...com; gregkh@...uxfoundation.org; Hyun Kwon
> > <hyunk@...inx.com>; Nava kishore Manne <navam@...inx.com>; Radhey
> > Shyam Pandey <radheys@...inx.com>; devicetree@...r.kernel.org; linux-
> > arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> > Subject: Re: [PATCH v3] Axi-usb: Add support for 64-bit addressing.
> > 
> > On Tuesday, May 24, 2016 10:51:08 AM CEST Nava kishore Manne wrote:
> > > diff --git a/Documentation/devicetree/bindings/usb/udc-xilinx.txt
> > > b/Documentation/devicetree/bindings/usb/udc-xilinx.txt
> > > index 47b4e39..09df757 100644
> > > --- a/Documentation/devicetree/bindings/usb/udc-xilinx.txt
> > > +++ b/Documentation/devicetree/bindings/usb/udc-xilinx.txt
> > > @@ -1,18 +1,23 @@
> > >  Xilinx USB2 device controller
> > >
> > >  Required properties:
> > > -- compatible		: Should be "xlnx,usb2-device-4.00.a"
> > > +- compatible		: Should be "xlnx,usb2-device-4.00.a" or
> > > +			  "xlnx,usb2-device-5.00"
> > >  - reg			: Physical base address and size of the USB2
> > >  			  device registers map.
> > >  - interrupts		: Should contain single irq line of USB2 device
> > >  			  controller
> > >  - xlnx,has-builtin-dma	: if DMA is included
> > > +- dma-ranges		: Should be as the following
> > > +			  <child-bus-address, parent-bus-address, length>
> > 
> > A USB host should not have any children that are DMA capable, I think, so
> > this property doesn't make sense here. It should be part of the parent bus.
> > 
> Will send next version (v4) by removing this property from the DT.
> 
> > > +- xlnx,addrwidth	: Should be the dma addressing size in bits(ex: 64
> > bits)
> > 
> > I'm still unconvinced about the property definition here. What are the
> > possible options for the IP block? I don't think I ever saw a reply from you to
> > my earlier questions.
> > 
> 
> Sorry Let me clearly explain
> 
> From the IP version 5.0 onwards The IP support both 32-bit and 64-bit addressing.
> But the older version of the IP's supports only 32-bit addressing.
> 
> This addrwidth property differentiates the address width for the new IP (I mean 5.0 version on wards)
> For older IP it will be always 32-bit.

Then I think you should have a simple boolean property for 64-bit 
configuration.