linux-kernel - Re: [PATCH v6] ASoC: cs53l30: Add codec driver support for Cirrus CS53L30

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160525173724.GA20293@Asurada-Nvidia>
Date:	Wed, 25 May 2016 10:37:24 -0700
From:	Nicolin Chen <nicoleotsuka@...il.com>
To:	Rob Herring <robh@...nel.org>
Cc:	broonie@...nel.org, brian.austin@...rus.com,
	Paul.Handrigan@...rus.com, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, lgirdwood@...il.com, Tim.Howe@...rus.com,
	somduttar@...dia.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH v6] ASoC: cs53l30: Add codec driver support for Cirrus
 CS53L30

On Wed, May 25, 2016 at 12:28:00PM -0500, Rob Herring wrote:

> > diff --git a/Documentation/devicetree/bindings/sound/cs53l30.txt b/Documentation/devicetree/bindings/sound/cs53l30.txt
> > new file mode 100644
> > index 0000000..ace7ffe
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/cs53l30.txt
> > @@ -0,0 +1,38 @@
> > +CS53L30 audio CODEC
> > +
> > +Required properties:
> > +
> > +  - compatible : "cirrus,cs53l30"
> > +
> > +  - reg : the I2C address of the device
> > +
> > +  - VA-supply, VP-supply : power supplies for the device,
> > +    as covered in Documentation/devicetree/bindings/regulator/regulator.txt.

> Also, these are missing from the example yet are required. I'd argue 
> they should be optional as you could have designs with no regulator 
> control.

Will refine both in next ver. Thanks