linux-kernel - Re: [PATCH V3 0/2] usb: musb: fix dropped packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160525200753.GA27089@uda0271908>
Date:	Wed, 25 May 2016 15:07:53 -0500
From:	Bin Liu <b-liu@...com>
To:	Andrew Goodbody <andrew.goodbody@...brionix.com>
CC:	<gregkh@...uxfoundation.org>, <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 0/2] usb: musb: fix dropped packets

Hi,

On Tue, May 24, 2016 at 09:22:32AM +0100, Andrew Goodbody wrote:
> The musb driver can drop rx packets when heavily loaded. These two
> patches address two issues that can cause this. Both issues arose
> when an endpoint was reprogrammed. The first patch is a logic bug
> that resulted in a shared_fifo in rx mode not having its state
> cleared out. The second patch fixes a race condition caused by
> not stopping the dedicated endpoint for bulk packets before
> rotating its queue which allowed a packet to be recieved and then
> thrown away.
> 
> V3 Updated the comment to better reference the manual
> V2 added a comment and removed debugging code
> 
> Andrew Goodbody (2):
>   usb: musb: Ensure rx reinit occurs for shared_fifo endpoints
>   usb: musb: Stop bulk endpoint while queue is rotated

Signed-off-by: Bin Liu <b-liu@...com>

Regards,
-Bin.

> 
>  drivers/usb/musb/musb_host.c | 21 +++++++++++++--------
>  1 file changed, 13 insertions(+), 8 deletions(-)
> 
> -- 
> 2.7.4
>