linux-kernel - Re: [PATCH v4] dell-rbtn: Ignore ACPI notifications if device is suspended

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57b87380-6ea8-cdaf-b95c-4685fc2a85d1@gmail.com>
Date:	Wed, 25 May 2016 22:47:03 +0200
From:	Gabriele Mazzotta <gabriele.mzt@...il.com>
To:	Pali Rohár <pali.rohar@...il.com>,
	Darren Hart <dvhart@...radead.org>
Cc:	arvidjaar@...il.com, rjw@...ysocki.net, Jared_Dominguez@...l.com,
	platform-driver-x86@...r.kernel.org, alex.hung@...onical.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] dell-rbtn: Ignore ACPI notifications if device is
 suspended

On 25/05/2016 22:36, Pali Rohár wrote:
> On Wednesday 25 May 2016 22:28:47 Darren Hart wrote:
>> On Tue, May 24, 2016 at 10:53:08PM +0200, Gabriele Mazzotta wrote:
>>> Some BIOSes unconditionally send an ACPI notification to RBTN when
>>> the system is resuming from suspend. This makes dell-rbtn send an
>>> input event to userspace as if a function key was pressed. Prevent
>>> this by ignoring all the notifications received while the device
>>> is suspended.
>>>
>>> Link: https://bugzilla.kernel.org/show_bug.cgi?id=106031
>>> Signed-off-by: Gabriele Mazzotta <gabriele.mzt@...il.com>
>>
>> Gabriele, please include all the maintainers on Cc (Pali was
>> missing).
> 
> Hehe, currently I started git send-email with my changes for v4 :D
> So doing CTRL+C in terminal...
> 
>> Pali, can I have your Reviewed-by?
> 
> Yes as my patch differs only in two words (in comments) :-)
> 
> Anyway, there is missing Andrei's tested-by (from v2 version).

Sorry, I think this was not the first time I excluded Pali's address...

Anyway, there's also Alex's tested-by from v2, which is basically
the same as v4.

> Maybe also this should go to stable tree?
>