linux-kernel - Re: [PATCH v6] platform:x86: Add PMC Driver for Intel Core SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160525210403.GD109010@f23x64.localdomain>
Date:	Wed, 25 May 2016 14:04:03 -0700
From:	Darren Hart <dvhart@...radead.org>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	Rajneesh Bhardwaj <rajneesh.bhardwaj@...el.com>,
	platform-driver-x86@...r.kernel.org,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Olof Johansson <olof@...om.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>, dbasehore@...gle.com,
	vishwanath.somayaji@...el.com
Subject: Re: [PATCH v6] platform:x86: Add PMC Driver for Intel Core SoC

On Wed, May 25, 2016 at 11:37:21PM +0300, Andy Shevchenko wrote:
> On Wed, May 25, 2016 at 11:13 PM, Darren Hart <dvhart@...radead.org> wrote:
> > On Wed, May 25, 2016 at 11:14:52PM +0530, Rajneesh Bhardwaj wrote:
> 
> > Hi Rajneesh,
> >
> > Unfortunately during my build test, this introduced a new warning to the build:
> >
> > drivers/platform/x86/intel_pmc_core.c:201:19: warning: ‘intel_pmc_core_init’
> > defined but not used [-Wunused-function]
> >  static int __init intel_pmc_core_init(void)
> >
> > After the removal of the module stuff, the driver needed a device_initcall, or
> > the macro equivalent, consider:
> >
> > $ git diff
> > diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
> > index c834281..f6a29b9 100644
> > --- a/drivers/platform/x86/intel_pmc_core.c
> > +++ b/drivers/platform/x86/intel_pmc_core.c
> > @@ -198,7 +198,4 @@ static struct pci_driver intel_pmc_core_driver = {
> 
> >         .remove = NULL, /* not a hot-plug capable driver */
> 
> Since it requires an update I would suggest to remove above line completely.

Indeed, thank you Andy.

-- 
Darren Hart
Intel Open Source Technology Center