linux-kernel - Re: [RFC PATCH] drivers/pinctrl: Add pinctrl-ast2400

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 26 May 2016 11:24:24 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Andrew Jeffery <andrew@...id.au>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Milton Miller II <miltonm@...ibm.com>,
	Joel Stanley <joel@....id.au>, Jeremy Kerr <jk@...abs.org>
Subject: Re: [RFC PATCH] drivers/pinctrl: Add pinctrl-ast2400

On Wed, May 25, 2016 at 7:22 AM, Andrew Jeffery <andrew@...id.au> wrote:
> [Me]
>> > +#define A4 2
>> > +SSSF_PIN_DECL(A4, GPIOA2, TIMER3, FUNC_DESC_SET(SCU80, 2));
>> > +
>> > +FUNC_EXPR_DECL_SINGLE(SD1, FUNC_DESC_SET(SCU90, 0));
>> > +
>> > +FUNC_EXPR_DECL_SINGLE(I2C10, FUNC_DESC_SET(SCU90, 23));
>> > +
>> > +#define C4 16
>> > +MS_PIN_DECL(C4, GPIOC0, SD1, I2C10);
>> > +#define B3 17
>> > +MS_PIN_DECL(B3, GPIOC1, SD1, I2C10);
>>
>> These things look very terse. But I guess there is no way to alleviate
>> the terseness that you can think of?
>
> Less terse in what way? Something other than more descriptive/longer
> the macro names?

Well I was just thinking that it's hard to read and understand.

But if it's complicated, it's complicated and that cannot be fixed
by syntax. Algebra books are not and easy read either, hehe :)

Yours,
Linus Walleij