[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <79d3b985-51a4-2a93-68a7-2ff968d92a93@arm.com>
Date: Thu, 26 May 2016 11:14:44 +0100
From: Julien Grall <julien.grall@....com>
To: Stefano Stabellini <sstabellini@...nel.org>,
Arnd Bergmann <arnd@...db.de>
Cc: Juergen Gross <jgross@...e.com>,
Stefano Stabellini <stefano.stabellini@...citrix.com>,
Daniel Kiper <daniel.kiper@...cle.com>,
Paul Gortmaker <paul.gortmaker@...driver.com>,
linux-kernel@...r.kernel.org, stable@...r.kernel.org,
Vitaly Kuznetsov <vkuznets@...hat.com>,
Julien Grall <julien.grall@...rix.com>,
Ross Lagerwall <ross.lagerwall@...rix.com>,
David Vrabel <david.vrabel@...rix.com>,
xen-devel@...ts.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@...cle.com>,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [Xen-devel] [PATCH] xen: remove incorrect forward declaration
Hi Stefano,
On 16/05/2016 12:11, Stefano Stabellini wrote:
> On Wed, 11 May 2016, Arnd Bergmann wrote:
>> A bugfix patch for the xen balloon driver introduced a forward
>> declaration for a static function that is conditionally compiled,
>> causing a warning if only the declaration but not the definition
>> are there:
>>
>> drivers/xen/balloon.c:154:13: error: 'release_memory_resource' declared 'static' but never defined [-Werror=unused-function]
>> static void release_memory_resource(struct resource *resource);
>>
>> This removes the declaration again and instead moves the function
>> definition to the right place, before its first caller and inside
>> of the #ifdef protecting both.
>>
>> The patch that introduced the warning is marked for stable
>> backports, so if that gets applied to 4.4, so should this one.
>>
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> Fixes: dfd74a1edfab ("xen/balloon: Fix crash when ballooning on x86 32 bit PAE")
>> Cc: stable@...r.kernel.org
>
> Reviewed-by: Stefano Stabellini <sstabellini@...nel.org>
You have applied this patch to the branch for-linus-4.8 but not
for-linus-4.7. Is it intentional?
Regards,
--
Julien Grall
Powered by blists - more mailing lists