linux-kernel - Re: [PATCH v2] f2fs: Return the errno to the caller to avoid using a wrong page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 May 2016 19:30:44 +0800
From:	Yunlong Song <yunlong.song@...wei.com>
To:	<jaegeuk@...nel.org>, <cm224.lee@...sung.com>,
	<yuchao0@...wei.com>, <chao@...nel.org>, <sylinux@....com>
CC:	<bintian.wang@...wei.com>, <houpengyang@...wei.com>,
	<heyunlei@...wei.com>, <liushuoran@...wei.com>,
	<shiguojun@...wei.com>, <linux-f2fs-devel@...ts.sourceforge.net>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] f2fs: Return the errno to the caller to avoid using a
 wrong page


>  page_hit:
> -	f2fs_bug_on(sbi, nid != nid_of_node(page));
> +	if(nid != nid_of_node(page)) {

should add "unlikely" here, will fix this in v3 patch.

> +		f2fs_bug_on(sbi, 1);
> +		ClearPageUptodate(page);
> +out_err:
> +		f2fs_put_page(page, 1);
> +		return ERR_PTR(-EIO);
> +	}
>  	return page;
>  }
>  
> 


-- 
Thanks,
Yunlong Song