linux-kernel - Re: [PATCH] Staging: android: ion: fixed a kzalloc coding style issue.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 May 2016 13:35:59 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	Shubham Bansal <illusionist.neo@...il.com>,
	gregkh@...uxfoundation.org, arve@...roid.com,
	riandrews@...roid.com, labbott@...hat.com, rohit.kr@...sung.com,
	gioh.kim@....com, daniel.vetter@...ll.ch,
	kirill.shutemov@...ux.intel.com, shawn.lin@...k-chips.com,
	dy@...xel.edu, neilzhang1123@...mail.com, eun.taik.lee@...sung.com,
	sriram@...irs.net.in, tiago.vignatti@...el.com
CC:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: android: ion: fixed a kzalloc coding style issue.

On 26/05/16 09:01, Shubham Bansal wrote:
> Fixed a coding style issue. Issue reported by checkpatch.pl.
> 
> Signed-off-by: Shubham Bansal <illusionist.neo@...il.com>
> ---
>  drivers/staging/android/ion/ion.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 8536567..2217ccb 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -184,7 +184,7 @@ static struct ion_buffer *ion_buffer_create(struct ion_heap *heap,
>  	struct scatterlist *sg;
>  	int i, ret;
>  
> -	buffer = kzalloc(sizeof(struct ion_buffer), GFP_KERNEL);
> +	buffer = kzalloc(sizeof(*buffer), GFP_KERNEL);
>  	if (!buffer)
>  		return ERR_PTR(-ENOMEM);
>  
> 


This patch looks good.

It is not a big issue, but have it in mind for the future. When fixing issues
reported by checkpatch, it is nice to paste the output warning of checkpatch
in the commit message.

Look at this example:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=e7a142aaa09fa5db015fd176d6943f888665829f

Thanks,
Luis