linux-kernel - Re: [PATCH 1/7] zram: rename zstrm find-release functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 26 May 2016 10:07:34 +0900
From:	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:	Minchan Kim <minchan@...nel.org>
Cc:	Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Joonsoo Kim <iamjoonsoo.kim@....com>,
	linux-kernel@...r.kernel.org,
	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
Subject: Re: [PATCH 1/7] zram: rename zstrm find-release functions

On (05/26/16 09:44), Minchan Kim wrote:
> On Wed, May 25, 2016 at 11:30:00PM +0900, Sergey Senozhatsky wrote:
> > We don't perform any zstream idle list lookup anymore, so
> > zcomp_strm_find()/zcomp_strm_release() names are not
> > representative.
> > 
> > Rename to zcomp_stream_get()/zcomp_stream_put().
> 
> Actually, I wanted it when we applied percpu but didn't say to you because
> 
> 1. It's preference of author.
> 
> Frankly speaking, I prefer get to find but you might think different
> with me so I want to respect patch author's right if it's not huge pain
> to me. :)
> Now I realized you were on same page.
> 
> 2. We might roll back to stream list.
> 
> In that case, find is proper word again but it's too trivial.
> So, I want to merge this patch regardless of this patchset. :)
> 
> > 
> > Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>
> > Cc: Minchan Kim <minchan@...nel.org>
> Acked-by: Minchan Kim <minchan@...nel.org>

thanks.

	-ss