linux-kernel - Re: [PATCH] blk-mq: clear q->mq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57470DCC.1060400@kernel.dk>
Date:	Thu, 26 May 2016 08:53:00 -0600
From:	Jens Axboe <axboe@...nel.dk>
To:	Ming Lin <mlin@...nel.org>, linux-kernel@...r.kernel.org,
	linux-block@...r.kernel.org
Cc:	Jens Axboe <axboe@...com>, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] blk-mq: clear q->mq_ops if init fail

On 05/26/2016 12:23 AM, Ming Lin wrote:
> From: Ming Lin <ming.l@...sung.com>
>
> blk_mq_init_queue() calls blk_mq_init_allocated_queue(), but q->mq_ops
> was not cleared when blk_mq_init_allocated_queue() fails.
> Then blk_cleanup_queue() calls blk_mq_free_queue() which will crash because:
> - q->all_q_node is not added to all_q_list yet
> - q->tag_set is NULL
> - hctx was not setup yet or already freed
>
> Fixed it by clearing q->mq_ops on error path.

Thanks Ming, applied for this series.

-- 
Jens Axboe