linux-kernel - Re: [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160526153414.GV2735@localhost>
Date:	Thu, 26 May 2016 21:04:15 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
	sakato <ryusuke.sakato.bx@...esas.com>,
	OSD2 ML <osd2@...renesas.com>, dmaengine@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dma: rcar-dmac: use list_add() on rcar_dmac_desc_put()

On Tue, May 24, 2016 at 12:50:28PM +0300, Laurent Pinchart wrote:

Hey Laurent,

> On Saturday 14 May 2016 13:27:31 Vinod Koul wrote:
> > On Fri, Apr 22, 2016 at 01:50:04AM +0000, Kuninori Morimoto wrote:
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> > > 
> > > Current rcar_dmac_desc_put() is using list_add_tail() in order to
> > > push used descriptor to list of free descriptors, and next DMA transfer
> > > try to reuse it from this list. But because it is using *_tail(),
> > > this reuse effect can't be obtained without using all of them.
> > > For a longer-term solution, we should allocate hardware descriptors
> > > using GFP_KERNEL instead of GFP_NOWAIT, but it is difficult today.
> > > This patch uses list_add() instead of list_add_tail() for short-term
> > > solution.
> > 
> > Applied, thanks
> 
> Thanks, but where did you apply it to ? I can't find it in your tree.

I changed my mind after this and felt that we should document above
in the changelog as well and replied to Kuninori few moments after this [1]

Sorry if that wasn't clear that am not applying this.

Please resend it with update changelog

[1]: http://www.spinics.net/lists/dmaengine/msg09585.html

-- 
~Vinod