linux-kernel - Re: [PATCH 1/1] net: nps_enet: Disable interrupts before napi reschedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1464285174.4578.36.camel@synopsys.com>
Date:	Thu, 26 May 2016 17:53:29 +0000
From:	Alexey Brodkin <Alexey.Brodkin@...opsys.com>
To:	"eladkan@...lanox.com" <eladkan@...lanox.com>
CC:	"linux-snps-arc@...ts.infradead.org" 
	<linux-snps-arc@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"noamca@...lanox.com" <noamca@...lanox.com>,
	Anton Kolesov <Anton.Kolesov@...opsys.com>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH 1/1] net: nps_enet: Disable interrupts before napi
 reschedule

Hi Elad,

On Thu, 2016-05-26 at 15:00 +0300, Elad Kanfi wrote:
> From: Elad Kanfi <eladkan@...lanox.com>
> 
> Since NAPI works by shutting down event interrupts when theres
> work and turning them on when theres none, the net driver must
> make sure that interrupts are disabled when it reschedules polling.
> By calling napi_reschedule, the driver switches to polling mode,
> therefor there should be no interrupt interference.
> Any received packets will be handled in nps_enet_poll by polling the HW
> indication of received packet until all packets are handled.
> 
> Signed-off-by: Elad Kanfi <eladkan@...lanox.com>
> Acked-by: Noam Camus <noamca@...lanox.com>
> ---
>  drivers/net/ethernet/ezchip/nps_enet.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ethernet/ezchip/nps_enet.c b/drivers/net/ethernet/ezchip/nps_enet.c
> index 085f912..06f0317 100644
> --- a/drivers/net/ethernet/ezchip/nps_enet.c
> +++ b/drivers/net/ethernet/ezchip/nps_enet.c
> @@ -205,8 +205,10 @@ static int nps_enet_poll(struct napi_struct *napi, int budget)
>  		 * re-adding ourselves to the poll list.
>  		 */
>  
> -		if (priv->tx_skb && !tx_ctrl_ct)
> +		if (priv->tx_skb && !tx_ctrl_ct) {
> +			nps_enet_reg_set(priv, NPS_ENET_REG_BUF_INT_ENABLE, 0);
>  			napi_reschedule(napi);
> +		}
>  	}
>  
>  	return work_done;

We just bumped into the same problem (data exchange hangs on the very first "ping")
with released Linux v4.6 and linux-next on our nSIM OSCI virtual platform.

I believe it was commit 05c00d82f4d1 ("net: nps_enet: bug fix - handle lost tx interrupts")
that introduced the problem. At least reverting it I got networking working.

And indeed that patch fixes mentioned issue.
In other words...

Tested-by: Alexey Brodkin <abrodkin@...opsys.com>

P.S. Given my observation is correct please add following to your commit
message if you ever do a respin:
------------------>8---------------
Fixes: 05c00d82f4d1 ("net: nps_enet: bug fix - handle lost tx interrupts")

Cc: <stable@...r.kernel.org> # 4.6.x
------------------>8---------------