linux-kernel - Re: [PATCH V3 1/2] i2c: qup: Fix broken dma when CONFIG_DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160526184805.GC1614@katana>
Date:	Thu, 26 May 2016 20:48:05 +0200
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Sricharan R <sricharan@...eaurora.org>
Cc:	linux-arm-msm@...r.kernel.org, ntelkar@...eaurora.org,
	galak@...eaurora.org, linux-kernel@...r.kernel.org,
	andy.gross@...aro.org, linux-i2c@...r.kernel.org,
	agross@...eaurora.org, linux-arm-kernel@...ts.infradead.org,
	nkaje@...eaurora.org, absahu@...eaurora.org
Subject: Re: [PATCH V3 1/2] i2c: qup: Fix broken dma when CONFIG_DEBUG_SG is
 enabled


> sg_set_buf expects that the buf parameter passed in should be from
> lowmem and a valid pageframe. This is not true for pages from
> dma_alloc_coherent which can be carveouts, hence the check fails.

OK, given you mean dma_pool_alloc here, the check fails for the
pageframe because of the pool? Is my understanding correct?

> Change allocation of sg buffers from dma_coherent memory to kzalloc
> to fix the issue.

But why can you drop the coherency?

> @@ -1268,6 +1260,8 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap,
>  		}
>  	}
>  
> +	idx = 0;
> +

This looks like an unrelated change.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)