linux-kernel - Re: can't boot with reiserfs on linux-4.6.0+

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 27 May 2016 06:49:10 +0800
From:	Jeff Chua <jeff.chua.linux@...il.com>
To:	Hillf Danton <hillf.zj@...baba-inc.com>
Cc:	Al Viro <viro@...iv.linux.org.uk>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: can't boot with reiserfs on linux-4.6.0+

On Thu, May 26, 2016 at 3:46 PM, Hillf Danton <hillf.zj@...baba-inc.com> wrote:
>> > See if this fixes your reproducer.
>> >
>> > diff --git a/fs/xattr.c b/fs/xattr.c
>> > index b11945e..49b8eab 100644
>> > --- a/fs/xattr.c
>> > +++ b/fs/xattr.c
>> > @@ -667,6 +667,9 @@ xattr_resolve_name(const struct xattr_handler **handlers, const char **name)
>> >  {
>> >         const struct xattr_handler *handler;
>> >
>> > +       if (!handlers)
>> > +               return NULL;
>> > +
>> >         if (!*name)
>> >                 return NULL;
>> >
>>
>> Tried, but doesn't work.
>>
> See if this fixes your reproducer.
>
> --- linux-4.6/fs/xattr.c        Mon May 16 06:43:13 2016
> +++ b/fs/xattr.c        Thu May 26 15:36:14 2016
> @@ -667,8 +667,8 @@ xattr_resolve_name(const struct xattr_ha
>  {
>         const struct xattr_handler *handler;
>
> -       if (!*name)
> -               return NULL;
> +       if (!handlers || !*name)
> +               return ERR_PTR(-EINVAL);
>
>         for_each_xattr_handler(handlers, handler) {
>                 const char *n;
> --

Hillf,

That worked and it's already in Linus's latest tree.

Thanks for sharing.

Jeff