linux-kernel - Re: [PATCH] dell-smm-hwmon: Cache fan_type() calls and use fan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10b66444-9405-9d4c-b1ec-ce57f7e8420f@leemhuis.info>
Date:	Fri, 27 May 2016 12:01:21 +0200
From:	Thorsten Leemhuis <fedora@...mhuis.info>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Jan C Peters <jcpeters89@...il.com>,
	David Santamaría Rogado <howl.nsp@...il.com>,
	Peter Saunderson <peteasa@...il.com>,
	Jean Delvare <jdelvare@...e.com>,
	Guenter Roeck <linux@...ck-us.net>,
	Tolga Cakir <cevelnet@...il.com>, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dell-smm-hwmon: Cache fan_type() calls and use
 fan_status() for fan detection

Pali Rohár wrote on 27.05.2016 11:47:
> On Friday 27 May 2016 10:00:05 Thorsten Leemhuis wrote:
>> Pali Rohár wrote on 26.05.2016 17:51:
>> > On Thursday 26 May 2016 17:39:57 Thorsten Leemhuis wrote:
>> >> > I need to know if this patch fixes problem on Dell Studio XPS 8000
>> >> > and Dell Studio XPS 8100 machines, so we can revert git commits:
>> >> > 6220f4ebd7b4 ("hwmon: (dell-smm) Blacklist Dell Studio XPS 8000")
>> >> > a4b45b25f18d ("hwmon: (dell-smm) Blacklist Dell Studio XPS 8100")
>> >> Just checked: Sorry, that patch did not fix the CPU fan speed issue
>> >> on my XPS 8000, so there is afaics no reason to revert 6220f4ebd7b4
>> >> :-/
>> > Please, can you apply patch "dell-smm-hwmon: In debug mode log duration 
>> > of SMM calls" 
> […] 
> I do not see any long taking SMM call here. Are you really sure that
> your machine freeze when loading or using dell-smm-hwmon?

Uhh, sorry, it seems something got mixed up somewhere. As mentioned
earlier in this thread already: The Studio XPS 8000 I have here never
froze when loading or using dell-smm-hwmon. I only saw its CPU fan speed
going up and down as described in
https://bugzilla.kernel.org/show_bug.cgi?id=100121 From the mail that
started this thread I got the impression that all those problems are all
related somehow, so I went testing the patch as asked.

CU, knurd