linux-kernel - Re: [RFC PATCH] usb: typec: Various API updates and fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57485471.3020505@roeck-us.net>
Date:	Fri, 27 May 2016 07:06:41 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	Felipe Balbi <felipe.balbi@...ux.intel.com>,
	Oliver Neukum <oneukum@...e.com>,
	Rajaram R <rajaram.officemail@...il.com>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [RFC PATCH] usb: typec: Various API updates and fixes

On 05/27/2016 12:55 AM, Heikki Krogerus wrote:
> Hi,
>

[ ... ]

>> ---
>> This patch applies on top of '[RFC PATCHv2] usb: USB Type-C Connector Class'
>> from Heikki Krogerus. It provided the changes I made to get the code
>> operational.
>>
>>   drivers/usb/type-c/typec.c | 134 ++++++++++++++++++++++++++++++++++++---------
>>   include/linux/usb/typec.h  |  26 ++++++---
>>   2 files changed, 125 insertions(+), 35 deletions(-)
>
> Thanks Guenter. After a quick glance looks good to me.
>
My pleasure.

> I think I'll create a development branch to my github tree for this
> class and add this on top of the original v2 patch as is. Just to have
> some history for as long we develop this thing. Though I'm not sure
> how useful it is in this case. I think we need to put this together
> fast. I'm thinking we need to target v4.8 with this.
>

Yes, agreed.

> I'll merge this into any case to v3, and I'll send on Monday.
>
Sounds good.

Couple of additional comments.

I don't really know what to do with the 'desc' field in struct typec_mode
for modes received from the partner. I wonder if it makes sense to display
it for partner modes.

Also, there is currently no attribute to show the partner identity (data
received from the Discover Identity command). Would it make sense to add
an 'identity' attribute to the partner device (plus an associated API
function to set it) ?

Thanks,
Guenter