linux-kernel - Re: [PATCH] acpi: cppc: Prevent cpc_desc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ5Y-ebkd6rbQkegdYUREn775Nu5jZqB3TBex5Rj1JsQ6Sjs-Q@mail.gmail.com>
Date:	Fri, 27 May 2016 12:10:04 -0400
From:	Ashwin Chaugule <ashwin.chaugule@...aro.org>
To:	Hoan Tran <hotran@....com>
Cc:	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Len Brown <lenb@...nel.org>,
	linux acpi <linux-acpi@...r.kernel.org>,
	lkml <linux-kernel@...r.kernel.org>, Duc Dang <dhdang@....com>,
	Loc Ho <lho@....com>
Subject: Re: [PATCH] acpi: cppc: Prevent cpc_desc_ptr points to the invalid data

On 25 May 2016 at 15:09, Hoan Tran <hotran@....com> wrote:
> When CPPC fails to request PCC channel, the CPC data is freed
> and cpc_desc_ptr points to the invalid data. This change prevents
> this issue by moving cpc_desc_ptr assignment after PCC channel
> request.
>
> Signed-off-by: Hoan Tran <hotran@....com>
> ---
>  drivers/acpi/cppc_acpi.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index 8adac69..85fd8f7 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -595,9 +595,6 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr)
>         /* Store CPU Logical ID */
>         cpc_ptr->cpu_id = pr->id;
>
> -       /* Plug it into this CPUs CPC descriptor. */
> -       per_cpu(cpc_desc_ptr, pr->id) = cpc_ptr;
> -
>         /* Parse PSD data for this CPU */
>         ret = acpi_get_psd(cpc_ptr, handle);
>         if (ret)
> @@ -610,6 +607,9 @@ int acpi_cppc_processor_probe(struct acpi_processor *pr)
>                         goto out_free;
>         }
>
> +       /* Plug PSD data into this CPUs CPC descriptor. */
> +       per_cpu(cpc_desc_ptr, pr->id) = cpc_ptr;
> +

Are you seeing a real problem without this change? I'm missing where
this pointer is dereferenced if the PCC channel request fails.

Thanks,
Ashwin.