linux-kernel - Re: [PATCH] arm: tegra124: remove commas from unit addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57489360.1030300@wwwdotorg.org>
Date:	Fri, 27 May 2016 12:35:12 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Marcel Ziswiler <marcel.ziswiler@...adex.com>
Cc:	devicetree@...r.kernel.org,
	Thierry Reding <thierry.reding@...il.com>,
	Kumar Gala <galak@...eaurora.org>,
	linux-kernel@...r.kernel.org,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>, linux-tegra@...r.kernel.org,
	Mark Rutland <mark.rutland@....com>,
	Alexandre Courbot <gnurou@...il.com>,
	Russell King <linux@...linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm: tegra124: remove commas from unit addresses

On 05/27/2016 10:27 AM, Marcel Ziswiler wrote:
> Remove commas from unit addresses as suggested by Rob Herring upon me
> posting initial Apalis TK1 support:
>
> http://article.gmane.org/gmane.linux.ports.tegra/26608

> diff --git a/arch/arm/boot/dts/tegra124-jetson-tk1.dts b/arch/arm/boot/dts/tegra124-jetson-tk1.dts

> -	gpu@0,57000000 {
> +	gpu@...00000 {
>   		/*
>   		 * Node left disabled on purpose - the bootloader will enable
>   		 * it after having set the VPR up

The last time a similar patch was proposed[1], I pointed out that U-Boot 
uses the node name to enable the node, so this change will break GPU 
functionality on this board. U-Boot has since been updated to find the 
node to enable using compatible value rather than hard-coding the node 
name, but this doesn't help people with existing bootloader binaries; 
kernel changes shouldn't force them to upgrade the bootloader. I think 
the DT node names are part of the ABI and shouldn't be changed. We can 
fix this for completely new SoCs, but not existing SoCs.

[1] http://www.spinics.net/lists/devicetree/msg122164.html "[PATCH] ARM: 
tegra: Remove 0, prefix from unit-addresses".