linux-kernel - Re: [PATCH v7] ASoC: cs53l30: Add codec driver support for Cirrus CS53L30

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160527203839.GE29837@sirena.org.uk>
Date:	Fri, 27 May 2016 21:38:39 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Nicolin Chen <nicoleotsuka@...il.com>
Cc:	robh+dt@...nel.org, brian.austin@...rus.com,
	Paul.Handrigan@...rus.com, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, lgirdwood@...il.com, Tim.Howe@...rus.com,
	somduttar@...dia.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH v7] ASoC: cs53l30: Add codec driver support for Cirrus
 CS53L30

On Wed, May 25, 2016 at 12:38:34PM -0700, Nicolin Chen wrote:

A few minor issues but this is mostly OK so I'll apply - please send
followup patches.

> +	SOC_DOUBLE_R_TLV("ADC1 Pre Amp Gain", CS53L30_ADC1A_AFE_CTL,
> +			 CS53L30_ADC1B_AFE_CTL, CS53L30_ADCxy_PREAMP_SHIFT,
> +			 2, 0, pga_preamp_tlv),
> +	SOC_DOUBLE_R_TLV("ADC2 Pre Amp Gain", CS53L30_ADC2A_AFE_CTL,
> +			 CS53L30_ADC2B_AFE_CTL, CS53L30_ADCxy_PREAMP_SHIFT,
> +			 2, 0, pga_preamp_tlv),

Volume controls should end Volume.

> +	regcache_cache_only(cs53l30->regmap, false);
> +	regcache_sync(cs53l30->regmap);

Should really check the return value here.

> +MODULE_AUTHOR("Paul Handrigan, Cirrus Logic Inc, <Paul.Handrigan@...rus.com>");

I'd have much preferred to have seen Paul's signoff on the patch.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)