linux-kernel - Re: [PATCH v4 3/4] iio: stx104: Allow build for X86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160527205255.GA27341@roeck-us.net>
Date:	Fri, 27 May 2016 13:52:55 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	William Breathitt Gray <vilhelm.gray@...il.com>
Cc:	gregkh@...uxfoundation.org, akpm@...ux-foundation.org,
	x86@...nel.org, linux-next@...r.kernel.org,
	linux-gpio@...r.kernel.org, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
	sfr@...b.auug.org.au, Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Peter Meerwald-Stadler <pmeerw@...erw.net>,
	Jonathan Cameron <jic23@...nel.org>
Subject: Re: [PATCH v4 3/4] iio: stx104: Allow build for X86_64

On Fri, May 27, 2016 at 03:54:00PM -0400, William Breathitt Gray wrote:
> On Fri, May 27, 2016 at 11:20:57AM -0700, Guenter Roeck wrote:
> >On Mon, May 23, 2016 at 08:31:07PM -0400, William Breathitt Gray wrote:
> >> With the introduction of the ISA_BUS_API Kconfig option, ISA-style
> >> drivers may be built for X86_64 architectures. This patch changes the
> >> ISA Kconfig option dependency of the Apex Embedded Systems STX104 DAC
> >> driver to ISA_BUS_API, thus allowing it to build for X86_64 as it is
> >> expected to.
> >> 
> >> Cc: Hartmut Knaack <knaack.h@....de>
> >> Cc: Lars-Peter Clausen <lars@...afoo.de>
> >> Cc: Peter Meerwald-Stadler <pmeerw@...erw.net>
> >> Cc: Jonathan Cameron <jic23@...nel.org>
> >> Signed-off-by: William Breathitt Gray <vilhelm.gray@...il.com>
> >> ---
> >>  drivers/iio/dac/Kconfig | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig
> >> index e63b957..315442f 100644
> >> --- a/drivers/iio/dac/Kconfig
> >> +++ b/drivers/iio/dac/Kconfig
> >> @@ -247,7 +247,7 @@ config MCP4922
> >>  
> >>  config STX104
> >>  	tristate "Apex Embedded Systems STX104 DAC driver"
> >> -	depends on X86 && ISA
> >> +	depends on ISA_BUS_API
> >
> >Assuming the dropped dependency on X86 is intentional:
> >
> >Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> 
> Thanks for the review Guenter: losing the X86 dependency was not
> intentional; it looks like I forgot to adjust this when I made
> ISA_BUS_API available to all architectures. I'll submit version 5 with
> the explicit X86 dependency back in place for CONFIG_STX104 and
> CONFIG_EBC_C384_WDT.
> 
Ok. Feel free to keep my Reviewed-by: tag unless you make further changes.

Guenter