linux-kernel - Re: [PATCH] remove lots of IS_ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwBcA9ViTxZ=bL=dP0CSWuLU7TY3OPpnYDjqbMsZY+fCQ@mail.gmail.com>
Date:	Fri, 27 May 2016 14:56:25 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrzej Hajda <a.hajda@...sung.com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	David Airlie <airlied@...ux.ie>,
	Robin Murphy <robin.murphy@....com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Russell King <linux@...linux.org.uk>,
	Bob Peterson <rpeterso@...hat.com>,
	Linux ACPI <linux-acpi@...r.kernel.org>,
	"open list:AMD IOMMU (AMD-VI)" <iommu@...ts.linux-foundation.org>,
	Linux Media Mailing List <linux-media@...r.kernel.org>,
	Network Development <netdev@...r.kernel.org>,
	Linux Wireless List <linux-wireless@...r.kernel.org>,
	V9FS Developers <v9fs-developer@...ts.sourceforge.net>
Subject: Re: [PATCH] remove lots of IS_ERR_VALUE abuses

On Fri, May 27, 2016 at 2:46 PM, Andrew Morton
<akpm@...ux-foundation.org> wrote:
>
> So you do plan to add some sort of typechecking into IS_ERR_VALUE()?

The easiest way to do it is to just turn the (x) into (unsigned
long)(void *)(x), which then complains about casting an integer to a
pointer if the integer has the wrong size.

But if we get rid of the bogus cases, there's just a few left, and we
should probably just rename the whole thing (the initial double
underscore). It really isn't something normal people should use.

          Linus