linux-kernel - Re: [PATCH] mtd: brcmnand: Add v7.2 controller support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160528200115.1cdb1d29@free-electrons.com>
Date:	Sat, 28 May 2016 20:01:15 +0200
From:	Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	linux-mtd@...ts.infradead.org, Mark Rutland <mark.rutland@....com>,
	Boris Brezillon <boris.brezillon@...e-electrons.com>,
	Pawel Moll <pawel.moll@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Richard Weinberger <richard@....at>,
	Kamal Dasu <kdasu.kdev@...il.com>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>,
	"open list:BROADCOM STB NAND FLASH DRIVER" 
	<bcm-kernel-feedback-list@...adcom.com>,
	Kumar Gala <galak@...eaurora.org>,
	Simon Arlott <simon@...e.lp0.eu>,
	Brian Norris <computersforpeace@...il.com>,
	David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH] mtd: brcmnand: Add v7.2 controller support

Hello,

On Fri, 27 May 2016 14:58:11 -0700, Florian Fainelli wrote:

> +	if (ctrl->nand_version >= 0x0702)
> +		bits = 7;
>  	if (ctrl->nand_version >= 0x0600)

Don't you want an "else if" here ?

Otherwise, even for the 7.2 version of your controller bits will be set
to 1.

Ditto when setting ctrl->max_oob.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com