linux-kernel - Re: WMI driver no longer load after switching to generic UUID library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFx72kwnogZDqJnBXdmjWsOzprJtyZxKFvpC4PT+RaAojQ@mail.gmail.com>
Date:	Sun, 29 May 2016 13:22:38 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Kui Zhang <kuizhang@...il.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	Darren Hart <dvhart@...ux.intel.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: WMI driver no longer load after switching to generic UUID library

Andy?

Looking at that commit, it does look like what wmi_parse_guid +
wmi_swap_bytes did was to implement a LE uuid. So the conversion looks
correct, but the fact that it breaks something obviously means that
there's something missing. What's going on?

And dammit, how I hate uuid's and the idiotic byte ordering issue.
It's possibly the only idiotic standard that is even worse than xml.

            Linus

On Sun, May 29, 2016 at 11:35 AM, Kui Zhang <kuizhang@...il.com> wrote:
> Hello,
>
> After commit 538d7eb86d58 ("drivers/platform/x86/wmi.c: use generic UUID library")
>
> some keyboard functions stopped working:
>
> clevo-wmi - git://git.code.sf.net/p/clevo-wmi/code
> [   83.877887] Clevo Get GUID not found
>
> /*
> #define CLWMI_GET_GUID "ABBC0F6D-8EA1-11d1-00A0-C90629100000"
>
> ...
>     if(!wmi_has_guid(CLWMI_GET_GUID)) {
>         pr_err("Clevo Get GUID not found\n");
>         return -ENODEV;
>     }
>
>
> */
>
> clevo-xsm-wmi - https://bitbucket.org/lynthium/clevo-xsm-wmi.git
> insmod: ERROR: could not insert module clevo-xsm-wmi.ko: No such device
>
> /*
>
> #define CLEVO_GET_GUID    "ABBC0F6D-8EA1-11D1-00A0-C90629100000"
>
> ...
>
>     if (!wmi_has_guid(CLEVO_GET_GUID)) {
>         CLEVO_XSM_INFO("No known WMI control method GUID found\n");
>         return -ENODEV;
>     }
>
> */
>
>
> thanks
> Kui.Z