linux-kernel - Re: [PATCH 1/1] iio: light: Added CM36672 Proximity Sensor Driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <68f15180-cba4-8afe-1237-be47ae3a7955@kernel.org>
Date:	Sun, 29 May 2016 17:23:37 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Peter Meerwald-Stadler <pmeerw@...erw.net>,
	Kevin Tsai <capellamicro@...il.com>
Cc:	Hartmut Knaack <knaack.h@....de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH 1/1] iio: light: Added CM36672 Proximity Sensor Driver.

On 29/05/16 09:55, Peter Meerwald-Stadler wrote:
> On Sat, 28 May 2016, Kevin Tsai wrote:
> 
>> Added Vishay Capella CM36672 Proximity Sensor IIO driver.  Support both
>> ACPI and Device Tree.
> 
> comments below
>  
>> Signed-off-by: Kevin Tsai <capellamicro@...il.com>
>> ---
<snip>
>> +#ifdef CONFIG_ACPI
>> +/**
>> + * cm36672_acpi_get_cpm_info() - Get CPM object from ACPI
>> + * @client:	pointer of struct i2c_client.
>> + * @obj_name:	pointer of ACPI object name.
>> + * @count:	maximum size of return array.
>> + * @vals:	pointer of array for return elements.
>> + *
>> + * Convert ACPI CPM table to array. Special thanks Srinivas Pandruvada's
> 
> thanks for
thanks to (if we are getting picky ;)
> 
>> + * help to implement this routine.
>> + *
>> + * Return: -ENODEV for fail. Otherwise is number of elements.
> 
> Otherwise the number of elements
>