linux-kernel - Re: [PATCH] mmc: core: fix the wrong error control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ad3f39a-9ff6-6992-d9d4-8bc411128219@kernel-upstream.org>
Date:	Mon, 30 May 2016 17:45:28 +0800
From:	Shawn Lin <shawn.lin@...nel-upstream.org>
To:	Jaehoon Chung <jh80.chung@...sung.com>, linux-mmc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Cc:	shawn.lin@...k-chips.com, ulf.hansson@...aro.org, arnd@...db.de,
	a.hajda@...sung.com, akpm@...ux-foundation.org,
	torvalds@...ux-foundation.org, k.kozlowski@...sung.com
Subject: Re: [PATCH] mmc: core: fix the wrong error control

Hi,

在 2016/5/30 15:40, Jaehoon Chung 写道:
> After applied "remove lots of IS_ERR_VALUE abuses", it shoold be
> misoperation. (commit 287980e49)
> If mmc_bus_test is successful, it returned the bus-witdh bit.
>
> The below log is error log
> [    2.542260] mmc0: mmc_select_hs200 failed, error 3
> [    2.542275] mmc0: error 3 whilst initialising MMC card
>

The same as this patch[0]?

[0]https://patchwork.kernel.org/patch/9139673/

> Signed-off-by: Jaehoon Chung <jh80.chung@...sung.com>
> ---
>  drivers/mmc/core/mmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index c984321..aafb73d 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -1276,7 +1276,7 @@ static int mmc_select_hs200(struct mmc_card *card)
>  	 * switch to HS200 mode if bus width is set successfully.
>  	 */
>  	err = mmc_select_bus_width(card);
> -	if (!err) {
> +	if (err > 0) {
>  		val = EXT_CSD_TIMING_HS200 |
>  		      card->drive_strength << EXT_CSD_DRV_STR_SHIFT;
>  		err = __mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
> @@ -1583,7 +1583,7 @@ static int mmc_init_card(struct mmc_host *host, u32 ocr,
>  	} else if (mmc_card_hs(card)) {
>  		/* Select the desired bus width optionally */
>  		err = mmc_select_bus_width(card);
> -		if (!err) {
> +		if (err > 0) {
>  			err = mmc_select_hs_ddr(card);
>  			if (err)
>  				goto free_card;
>