linux-kernel - Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160530023702.GB78763@jaegeuk.hsd1.ca.comcast.net>
Date:	Sun, 29 May 2016 19:37:02 -0700
From:	Jaegeuk Kim <jaegeuk@...nel.org>
To:	Chao Yu <chao@...nel.org>
Cc:	linux-f2fs-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, Chao Yu <yuchao0@...wei.com>
Subject: Re: [PATCH] f2fs: fix to redirty page if fail to gc data page

Hi Chao,

On Sat, May 21, 2016 at 01:19:11PM +0800, Chao Yu wrote:
> From: Chao Yu <yuchao0@...wei.com>
> 
> If we fail to move data page during foreground GC, we should give another
> chance to writeback that page which was set dirty previously by writer.
> 
> Signed-off-by: Chao Yu <yuchao0@...wei.com>
> ---
>  fs/f2fs/gc.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index 38d56f6..ee213a8 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -653,12 +653,15 @@ static void move_data_page(struct inode *inode, block_t bidx, int gc_type)
>  			.page = page,
>  			.encrypted_page = NULL,
>  		};
> +		bool is_dirty = PageDirty(page);
> +
>  		set_page_dirty(page);
>  		f2fs_wait_on_page_writeback(page, DATA, true);
>  		if (clear_page_dirty_for_io(page))
>  			inode_dec_dirty_pages(inode);
>  		set_cold_data(page);
> -		do_write_data_page(&fio);
> +		if (do_write_data_page(&fio) && is_dirty)
> +			set_page_dirty(page);

If this page is truncated with -ENOENT, we don't need to set it dirty again.
I expect that, if we get an error here, do_garbage_collect() would retry FG_GC
again.

Thanks,

>  		clear_cold_data(page);
>  	}
>  out:
> -- 
> 2.7.2