linux-kernel - Re: [PATCH v2 2/4] Staging: comedi: Fix WARNING issue in s626.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <574C4A29.5020906@osg.samsung.com>
Date:	Mon, 30 May 2016 15:11:53 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	Ravishankar Karkala Mallikarjunayya <ravishankarkm32@...il.com>,
	abbotti@....co.uk, hsweeten@...ionengravers.com,
	gregkh@...uxfoundation.org
CC:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] Staging: comedi: Fix WARNING issue in s626.c

On 28/05/16 06:26, Ravishankar Karkala Mallikarjunayya wrote:
> This is a patch to the s626.c file that fixes up a Block comments
> issues found by the checkpatch.pl tool.
> 
> i.e. Block comments use a trailing */ on a separate line
> 
> Signed-off-by: Ravishankar Karkala Mallikarjunayya <ravishankarkm32@...il.com>

We can see in the diff this is making changes in s626.c :) no need to mention
that in the commit message.

Not sure moving the opening and closing of comments (/* and */) to a new line
makes things more readable. checkpatch is a great tool but it gives suggestions,
not hard rules.
Just a comment since I've seen multiple people follow checkpatch blindly, and
it is best to use your discretion.

Maintainer of this code will probably have a preference.

Thank you for your patches Ravishankar.

Luis