linux-kernel - Re: [PATCH 12/17] sparc: get rid of superfluous __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160530.112335.1376503927443399332.davem@davemloft.net>
Date:	Mon, 30 May 2016 11:23:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mhocko@...nel.org
Cc:	akpm@...ux-foundation.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, mhocko@...e.com,
	linux-arch@...r.kernel.org
Subject: Re: [PATCH 12/17] sparc: get rid of superfluous __GFP_REPEAT

From: Michal Hocko <mhocko@...nel.org>
Date: Mon, 30 May 2016 11:14:54 +0200

> From: Michal Hocko <mhocko@...e.com>
> 
> __GFP_REPEAT has a rather weak semantic but since it has been introduced
> around 2.6.12 it has been ignored for low order allocations.
> 
> {pud,pmd}_alloc_one is using __GFP_REPEAT but it always allocates from
> pgtable_cache which is initialzed to PAGE_SIZE objects. This means that
> this flag has never been actually useful here because it has always been
> used only for PAGE_ALLOC_COSTLY requests.
> 
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: linux-arch@...r.kernel.org
> Signed-off-by: Michal Hocko <mhocko@...e.com>

Acked-by: David S. Miller <davem@...emloft.net>