linux-kernel - [PATCH 1/1] fs/proc/task_mmu.c: Include backslash when escaping file names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <574C7F29.9040301@nominal-animal.net>
Date:	Mon, 30 May 2016 20:58:01 +0300
From:	Nominal Animal <kernel@...inal-animal.net>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH 1/1] fs/proc/task_mmu.c: Include backslash when escaping file
 names

Files named "foo\nbar" and "foo\\012bar" are
both shown as "foo\\012bar" in /proc/PID files,
because show_map_vma() and show_numa_map() in fs/proc/task_mmu.c
do not include backslash in the escaped set when calling seq_file_path().
Fix this by including backslash in the escaped set.

diff -Nabpur linux-4.6/fs/proc/task_mmu.c linux-new/fs/proc/task_mmu.c
--- linux-4.6/fs/proc/task_mmu.c	2016-05-16 01:43:13.000000000 +0300
+++ linux-new/fs/proc/task_mmu.c	2016-05-30 19:55:42.247297498 +0300
@@ -329,7 +329,7 @@ show_map_vma(struct seq_file *m, struct
 	 */
 	if (file) {
 		seq_pad(m, ' ');
-		seq_file_path(m, file, "\n");
+		seq_file_path(m, file, "\n\\");
 		goto done;
 	}

@@ -1647,7 +1647,7 @@ static int show_numa_map(struct seq_file

 	if (file) {
 		seq_puts(m, " file=");
-		seq_file_path(m, file, "\n\t= ");
+		seq_file_path(m, file, "\n\t= \\");
 	} else if (vma->vm_start <= mm->brk && vma->vm_end >= mm->start_brk) {
 		seq_puts(m, " heap");
 	} else if (is_stack(proc_priv, vma, is_pid)) {

Regards,
  Nominal Animal