linux-kernel - Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1464680085.5978.40.camel@redhat.com>
Date:	Tue, 31 May 2016 09:34:45 +0200
From:	Gerd Hoffmann <kraxel@...hat.com>
To:	Daniel Vetter <daniel@...ll.ch>
Cc:	dri-devel <dri-devel@...ts.freedesktop.org>,
	open list <linux-kernel@...r.kernel.org>,
	"open list:VIRTIO GPU DRIVER" 
	<virtualization@...ts.linux-foundation.org>
Subject: Re: [PATCH v3 7/7] [wip] virtio-gpu: add page flip support

  Hi,

> > Right now the virtual outputs are linked to drm_crtc.  To apply any
> > changes I need to lookup the crtc to figure which virtual output should
> > be updated.

> > So, setting active_only should make sure I have a valid crtc pointer on
> > plane updates, right?  It probably also skips the disable + enable crtc
> > steps on commit?  What happens when outputs are disabled?

> Nah, I just misunderstood your patch. If it's all about finding the
> corresponding crtc, then you're all good.

Yes, it's all about finding the crtc.

> I thought there was some
> other reason (like the virtual hw getting upset about certain things).

virtio wouldn't be upset.

It's a pointless exercise though to first disable the output, just to
re-enable it the next moment with the new page-flipped framebuffer.  So
I guess I should look at the active_only thing nevertheless.

> btw can you pls drop an ack or r-b
> onto my virtio conversion? I already added your tested-by.

Grr, mail is not in my dri-devel folder.  Guess that is the <censored>
"avoid-duplicates" mailman option at work.

Feel free to just add the r-b too.  Or I'll send it for the next version
of the series.

cheers,
  Gerd