linux-kernel - Re: [RFC PATCH 2/4] mm: Change the interface for __tlb_remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <002b01d1baef$e6246530$b26d2f90$@alibaba-inc.com>
Date:	Tue, 31 May 2016 11:52:48 +0800
From:	"Hillf Danton" <hillf.zj@...baba-inc.com>
To:	"'Aneesh Kumar K.V'" <aneesh.kumar@...ux.vnet.ibm.com>
Cc:	"'linux-kernel'" <linux-kernel@...r.kernel.org>,
	<linux-mm@...ck.org>
Subject: Re: [RFC PATCH 2/4] mm: Change the interface for __tlb_remove_page

> >> @@ -1202,7 +1205,12 @@ again:
> >>  	if (force_flush) {
> >>  		force_flush = 0;
> >>  		tlb_flush_mmu_free(tlb);
> >> -
> >> +		if (pending_page) {
> >> +			/* remove the page with new size */
> >> +			__tlb_adjust_range(tlb, tlb->addr);
> >
> > Would you please specify why tlb->addr is used here?
> >
> 
> That is needed because tlb_flush_mmu_tlbonly() does a __tlb_reset_range().
> 
If ->addr is updated in resetting, then it is a noop here to deliver tlb->addr to
__tlb_adjust_range().
On the other hand, if ->addr is not updated in resetting, then it is also a noop here.

Do you want to update ->addr here?

thanks
Hillf