lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160531123622.GT4329@intel.com>
Date:	Tue, 31 May 2016 15:36:22 +0300
From:	Ville Syrjälä <ville.syrjala@...ux.intel.com>
To:	Gerd Hoffmann <kraxel@...hat.com>
Cc:	dri-devel@...ts.freedesktop.org,
	open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/5] add cursor hotspot to drm_framebuffer

On Tue, May 31, 2016 at 12:53:12PM +0200, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@...hat.com>
> ---
>  drivers/gpu/drm/drm_crtc.c | 2 ++
>  include/drm/drm_crtc.h     | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
> index d2a6d95..ce5a280 100644
> --- a/drivers/gpu/drm/drm_crtc.c
> +++ b/drivers/gpu/drm/drm_crtc.c
> @@ -2977,6 +2977,8 @@ static int drm_mode_cursor_universal(struct drm_crtc *crtc,
>  				DRM_DEBUG_KMS("failed to wrap cursor buffer in drm framebuffer\n");
>  				return PTR_ERR(fb);
>  			}
> +			fb->hot_x = req->hot_x;
> +			fb->hot_y = req->hot_y;
>  		} else {
>  			fb = NULL;
>  		}
> diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> index d1559cd..1460f66 100644
> --- a/include/drm/drm_crtc.h
> +++ b/include/drm/drm_crtc.h
> @@ -253,6 +253,8 @@ struct drm_framebuffer {
>  	int bits_per_pixel;
>  	int flags;
>  	uint32_t pixel_format; /* fourcc format */
> +	int hot_x;
> +	int hot_y;
>  	struct list_head filp_head;
>  };

Why store it in the fb and not eg. the plane state?

>  
> -- 
> 1.8.3.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Ville Syrjälä
Intel OTC

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ